tombentley commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-764649903
@dajac, @chia7712 I realise now that I was wrong about 2. It's not a problem because `KafkaFuture.whenComplete` and `thenApply` are using `KafkaFuture.BiConsumer` and `KafkaFuture.Function`, not the ones from `java.util.function`, and so they're distinct from the ones inherited from `CompletionStage`. It would mean subtly different behaviour between the overloaded methods, which isn't ideal, but it is possible. That leaves 1, which is a source incompatibility, but not a binary incompatibility. Perhaps, with the `@InterfaceStability.Evolving` that's enough to justify implementing `CompletionStage`, wdyt? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
