chia7712 commented on a change in pull request #9945:
URL: https://github.com/apache/kafka/pull/9945#discussion_r561947369
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1246,13 +1246,15 @@ class KafkaApis(val requestChannel: RequestChannel,
}
var clusterAuthorizedOperations = Int.MinValue
Review comment:
the default value of ```clusterAuthorizedOperations``` in auto-generated
protocol is ```-2147483648```. If the version of request is bigger than 10,
does it cause error if we set ```Int.MinValue``` to
```clusterAuthorizedOperations``` of ```MetadataResponseData```?
##########
File path: clients/src/main/resources/common/message/MetadataRequest.json
##########
@@ -31,7 +31,10 @@
// Starting in version 8, authorized operations can be requested for
cluster and topic resource.
//
// Version 9 is the first flexible version.
- // Version 10 add topicId
+ //
+ // Version 10 adds topicId.
+ //
+ // Version 11 deprecates IncludeClusterAuthorizedOperations field
(KIP-700).
Review comment:
How about saying this function is migrated to
```DescribeClusterRequest```?
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1246,13 +1246,15 @@ class KafkaApis(val requestChannel: RequestChannel,
}
var clusterAuthorizedOperations = Int.MinValue
Review comment:
Could you add the comments for that value (```Int.MinValue```) for dumb
readers like me :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
