dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r563168372
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1190,8 +1192,31 @@ class KafkaApis(val requestChannel: RequestChannel,
val metadataRequest = request.body[MetadataRequest]
val requestVersion = request.header.apiVersion
+ // Check if topicId is presented firstly.
+ val topicIds = metadataRequest.topicIds.asScala.toSet.filterNot(_ ==
Uuid.ZERO_UUID)
+ val supportedVersionTopicIds = if (config.interBrokerProtocolVersion >=
KAFKA_2_8_IV1) topicIds else Set.empty[Uuid]
Review comment:
Hello, I tried to add 2 test in `MetadataRequestBetweenDifferentIbpTest`
to verify these 2 cases, this test will take probably 10 seconds since we need
to constantly restart brokers to change the controller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
