jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r564244777



##########
File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java
##########
@@ -106,6 +120,14 @@
      */
     void updateHighWatermark(LogOffsetMetadata offsetMetadata);
 
+    /**
+     * Updates the log start offset if necessary.
+     *
+     * The replicated log's start offset can be increased when there is a 
snapshot greater than the
+     * current log start offset.
+     */
+    boolean updateLogStart(OffsetAndEpoch logStartSnapshotId);

Review comment:
       Done. Named it `deleteToNewOldestSnapshotId`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to