g1geordie commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r565002301



##########
File path: 
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java
##########
@@ -1004,10 +998,6 @@ public void testWithRecords(Args args) {
         }

Review comment:
       @chia7712  It seems like before . 
   But I think that checking all `new  MemoryRecordsBuilder ` will throw by 
some args is not easy.
   
   what do you think 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to