hachikuji commented on a change in pull request #9979:
URL: https://github.com/apache/kafka/pull/9979#discussion_r565525057
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -3365,6 +3366,44 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ def handleDescribeProducersRequest(request: RequestChannel.Request): Unit = {
+ val describeProducersRequest = request.body[DescribeProducersRequest]
+
+ def partitionError(topicPartition: TopicPartition, error: Errors):
DescribeProducersResponseData.PartitionResponse = {
+ new DescribeProducersResponseData.PartitionResponse()
+ .setPartitionIndex(topicPartition.partition)
+ .setErrorCode(error.code)
+ }
+
+ val response = new DescribeProducersResponseData()
+ describeProducersRequest.data.topics.forEach { topicRequest =>
+ val topicResponse = new DescribeProducersResponseData.TopicResponse()
+ .setName(topicRequest.name)
+ val topicError = if (!authHelper.authorize(request.context, READ, TOPIC,
topicRequest.name))
+ Some(Errors.TOPIC_AUTHORIZATION_FAILED)
+ else if (!metadataCache.contains(topicRequest.name))
+ Some(Errors.UNKNOWN_TOPIC_OR_PARTITION)
+ else
+ None
+
+ topicRequest.partitionIndexes.forEach { partitionId =>
+ val topicPartition = new TopicPartition(topicRequest.name, partitionId)
+ val partitionResponse = topicError match {
+ case Some(error) => partitionError(topicPartition, error)
+ case None => replicaManager.activeProducerState(topicPartition)
+ }
+ topicResponse.partitions.add(partitionResponse)
+ }
+
+ if (!topicResponse.partitions.isEmpty) {
+ response.topics.add(topicResponse)
+ }
Review comment:
Hmm... It's been a while since I wrote this. I agree it looks a little
strange. I guess there's probably no harm echoing back the same structure that
was sent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
