jolshan commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r565575532
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1223,7 +1251,7 @@ class KafkaApis(val requestChannel: RequestChannel,
Set.empty[MetadataResponseTopic]
else
unauthorizedForDescribeTopics.map(topic =>
- metadataResponseTopic(Errors.TOPIC_AUTHORIZATION_FAILED, topic,
false, util.Collections.emptyList()))
+ metadataResponseTopic(Errors.TOPIC_AUTHORIZATION_FAILED, topic,
Uuid.ZERO_UUID, false, util.Collections.emptyList()))
Review comment:
So will we never reach this code path when using topic IDs? I think we
are using topics to decide authorization. So in the case where we use ids and
the name exists, then we will expose the name and return a zero ID? Might be
useful to create an authorizer integration test with topic IDs to ensure
correctness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
