chia7712 commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r565826783
##########
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java
##########
@@ -1004,10 +998,6 @@ public void testWithRecords(Args args) {
}
Review comment:
@g1geordie I file a patch for aforementioned idea. Please take a look at
https://github.com/chia7712/kafka/pull/1/files
it uses explicit assert (exception or expected value) for all parameters
instead of just ignoring them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
