cadonna commented on pull request #9717: URL: https://github.com/apache/kafka/pull/9717#issuecomment-769037674
> honestly even I wasn't making the changes that I ended up making but I assumed that makeNext is the only method that needs to be tested wrt Range Iterator as other methods are inherited by it so those should have test cases separately. Fair point. I would agree, if we had tests for `RocksDbIterator`, but we haven't. I thought, it would be easier to restrict the tests to the range iterator and in a second step refactor the code to test also the parent class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org