[GitHub] [kafka] hachikuji commented on a change in pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

[GitBox]

hachikuji commented on a change in pull request #9967:
URL: https://github.com/apache/kafka/pull/9967#discussion_r566587032



##########
File path: core/src/main/scala/kafka/server/Server.scala
##########
@@ -46,6 +46,22 @@ object Server {
     new Metrics(metricConfig, reporters, time, true, metricsContext)
   }
 
+  def initializeMetrics(
+    config: KafkaConfig,
+    time: Time,
+    metaProps: MetaProperties

Review comment:
       @chia7712 We need the clusterId from `MetaProperties`. I modified this 
to pass it through directly avoid the duplicate methods.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org