ning2008wisc commented on pull request #9287: URL: https://github.com/apache/kafka/pull/9287#issuecomment-769983845
@mimaison @ryannedolan As titled, I think the change proposed in this PR may be preferred when tackling https://issues.apache.org/jira/browse/KAFKA-10339 (EOS) since lots of common logics can be reused. Given https://github.com/apache/kafka/pull/9451 has to be a big PR anyway, I slightly prefer to have the common logic extraction in a separate PR, like this one. But if your folks believe it looks better to have EOS and common logic extraction in one PR, that also sounds good to me :) Please invite other folks to chime in if needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
