rondagostino commented on a change in pull request #10009:
URL: https://github.com/apache/kafka/pull/10009#discussion_r569014431
##########
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##########
@@ -615,7 +615,7 @@ class TransactionCoordinator(brokerId: Int,
info("Shutting down.")
isActive.set(false)
scheduler.shutdown()
- producerIdManager.shutdown()
+ producerIdGenerator.shutdown()
Review comment:
It felt weird to create the instance in `apply()` and hand it off to
`TransactionCoordinator`, so I passed the factory and had the coordinator
generate the instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
