bob-barrett commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-773171300
@dajac @mimaison @satishd Thanks for your reviews! In addition to PR feedback, I pushed a new change to `ClusterConnectionStatesTest`. I noticed while testing locally that tests that depended on `kafka.apache.org` were failing. In https://github.com/apache/kafka/pull/9294, we changed the tests to assume that the site resolved to 3 IPv4 addresses. However, there appear to now be 2 IPv4 addresses and one IPv6, which broke the tests, since `ClientUtils#resolve` will only return the addresses of one version or the other, not both. With the `HostResolver` interface, it was straightforward to mock the DNS out instead of actually resolving `kafka.apache.org`, which should make the tests less fragile. This also may accomplish the intent of https://issues.apache.org/jira/browse/KAFKA-10496 without needing to create in-memory DNS. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
