cmccabe commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571119868
########## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ########## @@ -16,20 +16,20 @@ */ package kafka.server +import org.apache.kafka.common.{Node, TopicPartition, Uuid} + import java.util -import java.util.Collections import util.Arrays.asList - -import org.apache.kafka.common.{Node, TopicPartition, Uuid} import org.apache.kafka.common.message.UpdateMetadataRequestData.{UpdateMetadataBroker, UpdateMetadataEndpoint, UpdateMetadataPartitionState} import org.apache.kafka.common.network.ListenerName import org.apache.kafka.common.protocol.{ApiKeys, Errors} import org.apache.kafka.common.record.RecordBatch import org.apache.kafka.common.requests.UpdateMetadataRequest import org.apache.kafka.common.security.auth.SecurityProtocol -import org.junit.jupiter.api.Test import org.junit.jupiter.api.Assertions._ +import org.junit.jupiter.api.Test +import java.util.Collections import scala.jdk.CollectionConverters._ class MetadataCacheTest { Review comment: we should have some way of running these tests on the raft metadata cache as well as the zk metadata cache. I guess we can do that in a follow-up PR, though ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org