jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r572356813



##########
File path: 
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##########
@@ -110,7 +116,68 @@ public String toString() {
         }
     }
 
-    private Optional<Integer> optionalEpoch(int rawEpochValue) {
+    public static final class UnresolvedPartitions {

Review comment:
       The reason I name it this is we maintain such an object for each 
partition that was unresolved. If we simply have one object per topic, we would 
need a way to know all the partitions for the topic that were requested.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to