jolshan commented on a change in pull request #10041:
URL: https://github.com/apache/kafka/pull/10041#discussion_r572419692
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -256,7 +256,8 @@ class Log(@volatile private var _dir: File,
val topicPartition: TopicPartition,
val producerStateManager: ProducerStateManager,
logDirFailureChannel: LogDirFailureChannel,
- private val hadCleanShutdown: Boolean = true) extends Logging with
KafkaMetricsGroup {
+ private val hadCleanShutdown: Boolean = true,
+ val usesTopicId: Boolean = true) extends Logging with
KafkaMetricsGroup {
Review comment:
I named this based on the config's name. But the name you suggested is
more descriptive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
