MarcoLotz commented on a change in pull request #10042:
URL: https://github.com/apache/kafka/pull/10042#discussion_r573277614
##########
File path:
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java
##########
@@ -247,6 +268,26 @@ public void
shouldDetermineInternalTopicBasedOnTopicName1() {
assertTrue(streamsResetter.matchesInternalTopicFormat("appId-KTABLE-FK-JOIN-SUBSCRIPTION-REGISTRATION-12323232-topic"));
}
+ @Test
+ public void emptyPartitionsAreCorrectlyHandledWhenResettingByDateAndTime()
{
+ final MockConsumer<byte[], byte[]> emptyConsumer = new
EmptyPartitionConsumer<>(OffsetResetStrategy.EARLIEST);
+ final Duration yesterday = Duration.ofDays(1);
Review comment:
I've moved to the line just before L285. I would rather keep it there
instead of provide it straight on line L285. Keeping it on a variable makes the
//given //when //then more readable then providing straight in the //when call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
