cmccabe commented on a change in pull request #10093:
URL: https://github.com/apache/kafka/pull/10093#discussion_r573350073
##########
File path: tests/kafkatest/services/kafka/kafka.py
##########
@@ -171,35 +347,79 @@ def __init__(self, context, num_nodes, zk,
security_protocol=SecurityConfig.PLAI
# e.g. brokers to deregister after a hard kill.
self.zk_session_timeout = zk_session_timeout
- self.port_mappings = {
- 'PLAINTEXT': KafkaListener('PLAINTEXT', 9092, 'PLAINTEXT', False),
- 'SSL': KafkaListener('SSL', 9093, 'SSL', False),
- 'SASL_PLAINTEXT': KafkaListener('SASL_PLAINTEXT', 9094,
'SASL_PLAINTEXT', False),
- 'SASL_SSL': KafkaListener('SASL_SSL', 9095, 'SASL_SSL', False),
+ broker_only_port_mappings = {
KafkaService.INTERBROKER_LISTENER_NAME:
- KafkaListener(KafkaService.INTERBROKER_LISTENER_NAME, 9099,
None, False)
+ KafkaListener(KafkaService.INTERBROKER_LISTENER_NAME,
config_property.FIRST_BROKER_PORT + 7, None, False)
Review comment:
what happens if we have more brokers than 7? There are tests like that.
Should we use something like 700 here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
