[GitHub] [kafka] chia7712 commented on a change in pull request #10080: MINOR: KafkaBroker.brokerState should be volatile instead of AtomicReference

[GitBox]

chia7712 commented on a change in pull request #10080:
URL: https://github.com/apache/kafka/pull/10080#discussion_r573418590



##########
File path: core/src/main/scala/kafka/server/KafkaBroker.scala
##########
@@ -90,7 +92,7 @@ trait KafkaBroker extends KafkaMetricsGroup {
     explicitMetricName(KafkaBroker.metricsPrefix, KafkaBroker.metricsTypeName, 
name, metricTags)
   }
 
-  newGauge("BrokerState", () => brokerState.get.value())
+  newGauge("BrokerState", () => brokerState.value)

Review comment:
       (this is not related to this PR) it is a bit weird to me that we expose 
"byte" as "broker state".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org