[GitHub] [kafka] mimaison commented on a change in pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

[GitBox]

mimaison commented on a change in pull request #10112:
URL: https://github.com/apache/kafka/pull/10112#discussion_r578340374



##########
File path: 
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java
##########
@@ -1100,7 +1233,7 @@ private void assertPollMetrics(int 
minimumPollCountExpected) {
         double activeCountMax = 
metrics.currentMetricValueAsDouble(sourceTaskGroup, 
"source-record-active-count-max");
         assertEquals(0, activeCount, 0.000001d);
         if (minimumPollCountExpected > 0) {
-            assertEquals(RECORDS.size(), activeCountMax, 0.000001d);
+            assertEquals(activeCountMaxExpected, activeCountMaxExpected, 
0.000001d);

Review comment:
       Should the right hand side be `activeCountMax`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org