[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286114#comment-17286114 ]
Bill Bejeck edited comment on KAFKA-12213 at 2/18/21, 5:23 PM: --------------------------------------------------------------- Hi, [~MonCalamari]. I have an implementation for the ValueJoinerWithKey access, and I'll push a PR soon. As [~mjsax] pointed out, KIP-149 started before we had the Scala API, -and overloading the `join` method with a `ValueJoiner` and a `ValueJoinerWithKey` does cause issues with the Scala API. I'm working on proposed solutions, and I'll send out something on the dev mailing list soon.- EDIT: What I meant to say is that taking the same approach with the Scala API causes an issue. I'll investigate an approach and provide a follow-on PR. The current PR changes to the Java API [https://github.com/apache/kafka/pull/10150] do not cause any issue with the Scala API. I think considering this is a new addition it's acceptable to take an approach where we add this new functionality in steps But I don't have any plans at the moment to work on key access in the `Initializer` or `Reducer` parts of KIP-149 so feel free to move ahead with that part of the KIP-149 Thanks, Bill Bejeck was (Author: bbejeck): Hi, [~MonCalamari]. I have an implementation for the ValueJoinerWithKey access, and I'll push a PR soon. As [~mjsax] pointed out, KIP-149 started before we had the Scala API, and overloading the `join` method with a `ValueJoiner` and a `ValueJoinerWithKey` does cause issues with the Scala API. I'm working on proposed solutions, and I'll send out something on the dev mailing list soon. But I don't have any plans at the moment to work on key access in the `Initializer` or `Reducer` parts of KIP-149 so feel free to move ahead with that part of the KIP-149 Thanks, Bill Bejeck > Kafka Streams aggregation Initializer to accept record key > ---------------------------------------------------------- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams > Reporter: Piotr Fras > Assignee: Piotr Fras > Priority: Minor > Labels: needs-kip > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait-forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)