hachikuji commented on a change in pull request #10143:
URL: https://github.com/apache/kafka/pull/10143#discussion_r578638672
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -428,6 +428,43 @@ class Partition(val topicPartition: TopicPartition,
this.log = Some(log)
}
+ /**
+ * This method checks if the topic ID provided in the request is consistent
with the topic ID in the log.
+ * If a valid topic ID is provided, and the log exists but has no ID set,
set the log ID to be the request ID.
+ * Returns a boolean representing whether the topic ID was consistent.
Review comment:
nit: turn this into scaladoc and
```scala
* @return true if the request topic id is consistent, false otherwise
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
