mjsax commented on a change in pull request #10072:
URL: https://github.com/apache/kafka/pull/10072#discussion_r578937359
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -32,6 +33,7 @@
public final int topicGroupId;
/** The ID of the partition. */
public final int partition;
+ public Task task;
Review comment:
Passing the task into the `RecordCollector` also introduced a cyclic
dependency, as we pass the collector into the task. But getting the changelog
partitions within `handleCorrupted` makes sense -- it's actually even cleaner
to begin with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
