ijuma commented on pull request #10127: URL: https://github.com/apache/kafka/pull/10127#issuecomment-782234931
It's probably ok to leave as it is since these requests will eventually go away and this method is not used in the hot path, but the general pattern we want to follow is avoid generating new collections whenever possible in the request/response classes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org