hachikuji commented on a change in pull request #10157: URL: https://github.com/apache/kafka/pull/10157#discussion_r579954768
########## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ########## @@ -165,9 +165,19 @@ class DefaultAlterIsrManager( new ControllerRequestCompletionHandler { override def onComplete(response: ClientResponse): Unit = { debug(s"Received AlterIsr response $response") - val body = response.responseBody().asInstanceOf[AlterIsrResponse] val error = try { - handleAlterIsrResponse(body, message.brokerEpoch, inflightAlterIsrItems) + if (response.authenticationException != null) { + // For now we treat authentication errors as retriable. We use the + // `NETWORK_EXCEPTION` error code for lack of a good alternative. + // Note that `BrokerToControllerChannelManager` will still log the + // authentication errors so that users have a chance to fix the problem. + Errors.NETWORK_EXCEPTION + } else if (response.versionMismatch != null) { Review comment: Filed this: https://issues.apache.org/jira/browse/KAFKA-12353 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org