dajac commented on a change in pull request #10024:
URL: https://github.com/apache/kafka/pull/10024#discussion_r580113702



##########
File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala
##########
@@ -78,6 +77,8 @@ abstract class InterBrokerSendThread(
       failExpiredRequests(now)
       unsentRequests.clean()
     } catch {
+      case _: DisconnectException if !networkClient.active() =>
+        // Other threads can shutdown network client by calling 
InterBrokerSendThread#shutdown

Review comment:
       Could we also state the `DisconnectException` is expected when 
`NetworkClient#initiateClose` is called?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to