mjsax commented on a change in pull request #10170:
URL: https://github.com/apache/kafka/pull/10170#discussion_r580544814
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -792,7 +790,16 @@ public void punctuate(final ProcessorNode<?, ?, ?, ?> node,
throw new IllegalStateException(String.format("%sCurrent node is
not null", logPrefix));
}
- updateProcessorContext(node, time.milliseconds(), null);
+ // when punctuating, we need to preserve the timestamp (this can be
either system time or event time)
+ // while other record context are set as dummy: null topic, -1
partition, -1 offset and empty header
+ final ProcessorRecordContext recordContext = new
ProcessorRecordContext(
+ timestamp,
+ -1L,
+ -1,
+ null,
+ new RecordHeaders()
Review comment:
Why not pass `null` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
