mjsax commented on a change in pull request #10180:
URL: https://github.com/apache/kafka/pull/10180#discussion_r580731514



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -91,6 +91,7 @@
     // includes assigned & initialized tasks and unassigned tasks we locked 
temporarily during rebalance
     private final Set<TaskId> lockedTaskDirectories = new HashSet<>();
     private java.util.function.Consumer<Set<TopicPartition>> resetter;
+    private Map<TopicPartition, Long> committedOffsets = new HashMap<>();

Review comment:
       During a rebalance, we should delete all entries for partitions we don't 
own any longer.
   
   Should we also pre-populate this map when we init a task (cf 
`StreamsTask#initializeMetadata()`)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to