chia7712 commented on a change in pull request #10183:
URL: https://github.com/apache/kafka/pull/10183#discussion_r580788136
##########
File path:
clients/src/main/resources/common/message/DescribeProducersResponse.json
##########
@@ -35,7 +35,7 @@
{ "name": "ErrorMessage", "type": "string", "versions": "0+",
"nullableVersions": "0+", "default": "null",
"about": "The partition error message, which may be null if no
additional details are available" },
{ "name": "ActiveProducers", "type": "[]ProducerState", "versions":
"0+", "fields": [
- { "name": "ProducerId", "type": "int64", "versions": "0+" },
+ { "name": "ProducerId", "type": "int64", "versions": "0+",
"entityType": "producerId" },
{ "name": "ProducerEpoch", "type": "int32", "versions": "0+" },
Review comment:
The type confuses me. `DescribeProducersResponse` and this protocol use
`int64` but other protocols choose `int32`. Also, the type of
`TransactionMetadata#producerEpoch` is `short` rather than `integer`. Which one
is correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
