sknop commented on a change in pull request #9950:
URL: https://github.com/apache/kafka/pull/9950#discussion_r580882032
##########
File path:
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java
##########
@@ -364,11 +365,31 @@ private static String castToString(Object value) {
if (value instanceof java.util.Date) {
java.util.Date dateValue = (java.util.Date) value;
return Values.dateFormatFor(dateValue).format(dateValue);
+ } else if (value instanceof ByteBuffer) {
+ ByteBuffer byteBuffer = (ByteBuffer) value;
+ if (byteBuffer.hasArray()) {
+ return castByteArrayToString(byteBuffer.array());
+ }
+ else {
+ byte[] array = new byte[byteBuffer.remaining()];
+ byteBuffer.get(array);
+ return castByteArrayToString(array);
+ }
Review comment:
This sounds like an excellent plan and passes the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
