[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

[GitBox]

dengziming commented on a change in pull request #10021:
URL: https://github.com/apache/kafka/pull/10021#discussion_r582587332



##########
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##########
@@ -341,7 +342,7 @@ object KafkaMetadataLog {
         }
       }
 
-    val replicatedLog = new KafkaMetadataLog(log, snapshotIds, topicPartition, 
maxFetchSizeInBytes)
+    val replicatedLog = new KafkaMetadataLog(log, scheduler, snapshotIds, 
topicPartition, maxFetchSizeInBytes)

Review comment:
       I also find it's awkward to represent snapshot files using 
`OffsetAndEpoch` but we need to rely on `Snapshots` to remove and delete 
snapshots, will file a ticket to discuss consolidating file management, the 
first thought is to add  `MetadataLogSnapshot` class to represent a snapshot 
file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org