mimaison commented on a change in pull request #10185:
URL: https://github.com/apache/kafka/pull/10185#discussion_r583764462
##########
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
##########
@@ -455,27 +470,44 @@ private static void
waitUntilMirrorMakerIsRunning(EmbeddedConnectCluster connect
"Connector " + connector.getSimpleName() + " tasks did not
start in time on cluster: " + connectCluster);
}
}
-
+
+ /*
+ * wait for the topic created on the cluster
+ */
+ private static void waitForTopicCreated(EmbeddedKafkaCluster cluster,
String topicName) throws InterruptedException {
+ try (final Admin adminClient = cluster.createAdminClient()) {
+ waitForCondition(() ->
adminClient.listTopics().names().get().contains(topicName),
OFFSET_SYNC_DURATION_MS,
+ "Topic: " + topicName + " didn't get created in the cluster"
+ );
+ }
+ }
+
/*
* delete all topics of the input kafka cluster
*/
private static void deleteAllTopics(EmbeddedKafkaCluster cluster) throws
Exception {
- Admin client = cluster.createAdminClient();
- client.deleteTopics(client.listTopics().names().get());
+ try (final Admin adminClient = cluster.createAdminClient()) {
+ Set<String> topicsToBeDeleted =
adminClient.listTopics().names().get();
+ log.debug("Deleting topics: {} ", topicsToBeDeleted);
+ adminClient.deleteTopics(topicsToBeDeleted).all().get();
+ } catch (final Throwable e) {
Review comment:
Catching `Throwable` will also catch errors which I don't think we want
to do. But I don't even think we want to catch all exceptions and rethrow them
as unchecked.
The `deleteAllTopics` method is already marked as throwing `Exception`. If
anything is thrown, we can let it bubble up and fail the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
