chia7712 commented on a change in pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#discussion_r586390524
##########
File path:
clients/src/test/java/org/apache/kafka/common/requests/LeaderAndIsrRequestTest.java
##########
@@ -59,18 +61,41 @@ public void testUnsupportedVersion() {
@Test
public void testGetErrorResponse() {
- Uuid id = Uuid.randomUuid();
+ Uuid topicId = Uuid.randomUuid();
+ String topicName = "topic";
+ int partition = 0;
+
for (short version = LEADER_AND_ISR.oldestVersion(); version <
LEADER_AND_ISR.latestVersion(); version++) {
Review comment:
It does not cover all versions. I had filed a PR for that (#10078) but I
feel it can be fixed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
