hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r589600950
##########
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##########
@@ -198,15 +242,18 @@ class MetadataPartitionsBuilder(val brokerId: Int,
}
changed.add(newPartitionMap)
newNameMap.put(topicName, newPartitionMap)
+ prevPartition
}
}
+ removedPartition.foreach(maybeAddToLocalRemoved)
}
}
def build(): MetadataPartitions = {
- val result = MetadataPartitions(newNameMap, newIdMap)
+ val result = new MetadataPartitions(newNameMap, newIdMap, newReverseIdMap)
Review comment:
I would say yes if there was a cheap way to do it. However, I don't
think it's unreasonable to depend on internally maintained invariants here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
