mjsax commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r591997331
##########
File path: build.gradle
##########
@@ -1416,14 +1416,6 @@ project(':streams') {
dependencies {
api project(':clients')
- // use `api` dependency for `connect-json` for compatibility (e.g. users
who use `JsonSerializer`/`JsonDeserializer`
- // at compile-time without an explicit dependency on `connect-json`)
- // this dependency should be removed after we unify data API
- api(project(':connect:json')) {
- // this transitive dependency is not used in Streams, and it breaks SBT
builds
- exclude module: 'javax.ws.rs-api'
- }
-
implementation libs.slf4jApi
implementation libs.rocksDBJni
implementation libs.jacksonAnnotations
Review comment:
SGTM.
Back in the days, KafkaStreams did not use anything JSON related, but in a
later version we actually added this dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
