jolshan commented on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-796886007
@chia7712 There was a lot of back and forth about whether we should simply include the topic ID in the protocol (to uniquely identify the topic--which is something we may want to do to make sure we are consuming the right topic) versus use the topic ID to replace the topic name. The main arguments were: 1. Topic IDs are in most cases shorter than topic names so we can shorten an already somewhat large protocol 2. We will eventually want to move over to using topic IDs for everything so we might as well make this change now. I do agree that the TopicPartitions used make this task much harder and I tried to find a clean way to accomplish this. The main idea is that we keep track of topics that did not have topic ids server-side (receiving-side) and send an error response back. The idea is that the sender will always have the topic ID -> name conversion for topic IDs it sends. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
