hachikuji commented on a change in pull request #10135: URL: https://github.com/apache/kafka/pull/10135#discussion_r593485718
########## File path: core/src/main/scala/kafka/server/BrokerServer.scala ########## @@ -179,17 +181,16 @@ class BrokerServer( val controllerNodes = RaftConfig.quorumVoterStringsToNodes(controllerQuorumVotersFuture.get()).asScala val controllerNodeProvider = RaftControllerNodeProvider(metaLogManager, config, controllerNodes) - val forwardingChannelManager = BrokerToControllerChannelManager( + clientToControllerChannelManager = BrokerToControllerChannelManager( controllerNodeProvider, time, metrics, config, - channelName = "forwarding", + channelName = "clientToControllerChannel", Review comment: How about "controllerForwardingChannel"? I think it fits for both cases we're handling. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org