[GitHub] [kafka] ableegoldman commented on a change in pull request #10232: KAFKA-12352: Make sure all rejoin group and reset state has a reason

[GitBox]

ableegoldman commented on a change in pull request #10232:
URL: https://github.com/apache/kafka/pull/10232#discussion_r593521930



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -775,8 +776,6 @@ public void handle(SyncGroupResponse syncResponse,
                     }
                 }
             } else {
-                requestRejoin();

Review comment:
       Hmm...but `resetStateAndRejoin(String.format("rebalance failed with 
retriable error %s", exception));` is only called in `joinGroupIfNeeded`  which 
is only called in `ensureActiveGroup`, which is in turn only invoked in 
`ConsumerCoordinator#poll`.
   That said,  inside `SyncGroupResponseHandler#handle` we would already have 
`rejoinNeeded = true` and only set it to false if the SyncGroup succeeds. So 
for that reason I guess we don't need the `requestRejoin` anywhere inside the 
SyncGroup handler




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org