cmccabe commented on pull request #10297: URL: https://github.com/apache/kafka/pull/10297#issuecomment-800668936
Sure, we can refactor this later if it's that easier. Can you add a comment to `SecurityConfig#enabled_sasl_mechanisms` describing what it's supposed to return, though? If it should return every possible sasl mechanism in use (zk, controller, broker, client) then let's document that ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org