rondagostino commented on a change in pull request #10292:
URL: https://github.com/apache/kafka/pull/10292#discussion_r596082828



##########
File path: tests/kafkatest/tests/client/client_compatibility_features_test.py
##########
@@ -79,14 +79,16 @@ def __init__(self, test_context):
             "replication-factor": 3
             }}
         self.kafka = KafkaService(test_context, num_nodes=3, zk=self.zk, 
topics=self.topics)
+        # Always use the latest version of 
org.apache.kafka.tools.ClientCompatibilityTest
+        # so store away the path to the DEV version before we set the Kafka 
version
+        self.dev_script_path = self.kafka.path.script("kafka-run-class.sh", 
self.kafka.nodes[0])
 
     def invoke_compatibility_program(self, features):
-        # Run the compatibility test on the first Kafka node.

Review comment:
       nit: no need to remove this comment.  Otherwise LGTM -- thank you again!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to