chia7712 commented on a change in pull request #10334: URL: https://github.com/apache/kafka/pull/10334#discussion_r596497253
########## File path: metadata/src/main/java/org/apache/kafka/timeline/BaseHashTable.java ########## @@ -56,12 +56,29 @@ this.elements = new Object[expectedSizeToCapacity(expectedSize)]; } + /** + * Calculate the capacity we should provision, given the expected size. + * + * Our capacity must always be a power of 2, and never less than 2 or more + * than MAX_CAPACITY. We use 64-bit numbers here to avoid overflow + * concerns. + */ + @SuppressWarnings("unchecked") Review comment: Is this necessary? my IDE says it is redundant. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org