jolshan commented on a change in pull request #10351:
URL: https://github.com/apache/kafka/pull/10351#discussion_r597863428
##########
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##########
@@ -930,6 +930,28 @@ public void
testCreateTopicRequestV3FailsIfNoPartitionsOrReplicas() {
assertTrue(exception.getMessage().contains("[foo, bar]"));
}
+ @Test
+ public void testDeleteTopicsRequestNumTopics() {
+ for (short version : DELETE_TOPICS.allVersions()) {
+ DeleteTopicsRequest request = createDeleteTopicsRequest(version);
+ DeleteTopicsRequest serializedRequest =
DeleteTopicsRequest.parse(request.serialize(), version);
+ // createDeleteTopicsRequest sets 2 topics
+ assertEquals(2, request.numberOfTopics());
+ assertEquals(2, serializedRequest.numberOfTopics());
Review comment:
I think the reason I didn't put it in `DeleteTopicsRequestTest` is also
because that is an integration test. Would it make sense to rename that and
create a unit test called DeleteTopicsRequestTest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
