ijuma commented on a change in pull request #10371:
URL: https://github.com/apache/kafka/pull/10371#discussion_r598744847
##########
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##########
@@ -708,30 +711,35 @@ object ConsumerGroupCommand extends Logging {
options.timeoutMs(t)
}
- private def parseTopicPartitionsToReset(groupId: String, topicArgs:
Seq[String]): Seq[TopicPartition] = topicArgs.flatMap {
- case topicArg if topicArg.contains(":") =>
- val topicPartitions = topicArg.split(":")
+ private def parseTopicPartitionsToReset(topicArgs: Seq[String]):
Seq[TopicPartition] = {
+ val (topicsWithPartitions, topics) = topicArgs.partition(_.contains(":"))
+ val specifiedPartitions = topicsWithPartitions.flatMap { arg =>
+ val topicPartitions = arg.split(":")
Review comment:
I see that Rajini has the extra case in her changes, so all good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
