kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602056301
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -213,32 +208,38 @@ case object SnapshotGenerated extends
LogStartOffsetIncrementReason {
}
/**
- * An append-only log for storing messages.
+ * A log which presents a unified view of local and tiered log segments.
*
- * The log is a sequence of LogSegments, each with a base offset denoting the
first message in the segment.
+ * The log consists of tiered and local segments with the tiered portion of
the log being optional. There could be an
+ * overlap between the tiered and local segments. The active segment is always
guaranteed to be local. If tiered segments
+ * are present, they always appear at the head of the log, followed by an
optional region of overlap, followed by the local
+ * segments including the active segment.
*
- * New log segments are created according to a configurable policy that
controls the size in bytes or time interval
- * for a given segment.
+ * NOTE: this class handles state and behavior specific to tiered segments as
well as any behavior combining both tiered
+ * and local segments. The state and behavior specific to local segments is
handled by the encapsulated LocalLog instance.
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
