wcarlson5 commented on a change in pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#discussion_r602472401



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -492,22 +492,18 @@ private void handleStreamsUncaughtException(final 
Throwable throwable,
                 closeToError();
                 break;
             case SHUTDOWN_APPLICATION:
+                if (getNumLiveStreamThreads() <= 1) {

Review comment:
       I wasn't sure about how to inject an error into an only global topology. 
But I figured what we really needed to test was if we can add a thread to a 
global-only topology. So I did that WDYT?
   
   It will hit an illegal state exception as "Consumer is not subscribed to any 
topics or assigned any partitions" but that is after it will have resized the 
cache and after the shutdown rebalance has been triggered




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to