ableegoldman commented on a change in pull request #10416:
URL: https://github.com/apache/kafka/pull/10416#discussion_r602495343



##########
File path: 
streams/src/test/java/org/apache/kafka/test/MockRocksDbConfigSetter.java
##########
@@ -32,4 +32,9 @@ public void setConfig(final String storeName, final Options 
options, final Map<S
 
         configMap.putAll(configs);
     }
+
+    @Override
+    public void close(String storeName, Options options) {
+        LOG.warn("The default close was removed in 3.0.0 -- you should 
overwrite it if you have implemented RocksDBConfigSetter");

Review comment:
       I think this mock is probably only used internally by Streams tests, so 
we don't need to log anything for users here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to