guozhangwang commented on a change in pull request #10378:
URL: https://github.com/apache/kafka/pull/10378#discussion_r602811233
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java
##########
@@ -73,33 +72,16 @@
public final class SessionWindows {
private final long gapMs;
- private final long maintainDurationMs;
- private final long graceMs;
+ // By default grace period is 24 hours,
+ // in other words we allow out-of-order data for up to a day
Review comment:
That's actually a great point. I will remove all these on inherited
classes and only leave a comment on top of `DEFAULT_GRACE_PERIOD_MS`. When we
change it later, we only need to change the single comment there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
