satishd commented on a change in pull request #10424:
URL: https://github.com/apache/kafka/pull/10424#discussion_r603432281
##########
File path:
clients/src/main/java/org/apache/kafka/server/log/remote/storage/LogSegmentData.java
##########
@@ -30,28 +30,27 @@
@InterfaceStability.Evolving
public class LogSegmentData {
- private final File logSegment;
- private final File offsetIndex;
- private final File timeIndex;
- private final File txnIndex;
- private final File producerSnapshotIndex;
+ private final Path logSegment;
+ private final Path offsetIndex;
+ private final Path timeIndex;
+ private final Path txnIndex;
+ private final Path producerSnapshotIndex;
private final ByteBuffer leaderEpochIndex;
/**
* Creates a LogSegmentData instance with data and indexes.
- *
- * @param logSegment actual log segment file
+ * @param logSegment actual log segment file
* @param offsetIndex offset index file
* @param timeIndex time index file
* @param txnIndex transaction index file
* @param producerSnapshotIndex producer snapshot until this segment
* @param leaderEpochIndex leader-epoch-index until this segment
*/
- public LogSegmentData(File logSegment,
- File offsetIndex,
- File timeIndex,
- File txnIndex,
- File producerSnapshotIndex,
+ public LogSegmentData(Path logSegment,
Review comment:
Keeping these as `Path` for now instead of readable FileChannels as
mentioned
[here](https://github.com/apache/kafka/pull/10173#discussion_r600657753). S3
client APIs have nice and easy utils that take files and transfer the content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
