dajac commented on a change in pull request #10436:
URL: https://github.com/apache/kafka/pull/10436#discussion_r604176897



##########
File path: docs/upgrade.html
##########
@@ -28,6 +28,8 @@ <h5><a id="upgrade_300_notable" 
href="#upgrade_300_notable">Notable changes in 3
     <li>The Streams API removed all deprecated APIs that were deprecated in 
version 2.5.0 or earlier.
         For a complete list of removed APIs compare the detailed Kafka Streams 
upgrade notes.</li>
     <li>The deprecated <code>Metric#value()</code> method was removed (<a 
href="https://issues.apache.org/jira/browse/KAFKA-12573";>KAFKA-12573</a>).</li>
+    <li>The deprecated <code>org.apache.kafka.clients.admin.ConfigEntry</code> 
constructor was removed (<a 
href="https://issues.apache.org/jira/browse/KAFKA-12577";>KAFKA-12577</a>).

Review comment:
       We have multiple `ConfigEntry` classes in the code base so I used the 
fully qualified name to be precise. `Metric` is unique however. Shall we use 
the fully qualified name for `Metric` as well in order to be consistent?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to