ijuma commented on a change in pull request #10435:
URL: https://github.com/apache/kafka/pull/10435#discussion_r604182448
##########
File path:
clients/src/main/java/org/apache/kafka/common/acl/AclBindingFilter.java
##########
@@ -50,18 +48,6 @@ public AclBindingFilter(ResourcePatternFilter patternFilter,
AccessControlEntryF
this.entryFilter = Objects.requireNonNull(entryFilter, "entryFilter");
}
- /**
- * Create an instance of this filter with the provided parameters.
- *
- * @param resourceFilter non-null resource filter
- * @param entryFilter non-null access control entry filter
- * @deprecated Since 2.0. Use {@link
#AclBindingFilter(ResourcePatternFilter, AccessControlEntryFilter)}
- */
- @Deprecated
- public AclBindingFilter(ResourceFilter resourceFilter,
AccessControlEntryFilter entryFilter) {
Review comment:
Good point, this is not used anymore. It's not deprecated, but given
that it's not used anywhere, it seems fair to remove it at the same time.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
